poorbarcode commented on code in PR #4128:
URL: https://github.com/apache/bookkeeper/pull/4128#discussion_r1389076973
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/net/NetworkTopologyImplTest.java:
##########
@@ -65,6 +65,35 @@ public void getLeavesShouldReturnNodesInScope() {
assertTrue(leavesScopeRack1.contains(bookieRack1ScopeNode));
}
+ @Test
+ public void testRestartBKWithNewRackDepth() {
+ NetworkTopologyImpl networkTopology = new NetworkTopologyImpl();
+ String dp1Rack = "/rack-1";
+ String dp2Rack = "/dp/rack-1";
+ BookieId bkId1 = BookieId.parse("bookieIdScopeRack0");
+ BookieId bkId2 = BookieId.parse("bookieIdScopeRack1");
+
+ // Register 2 BKs with depth 1 rack.
+ BookieNode dp1BkNode1 = new BookieNode(bkId1, dp1Rack);
+ BookieNode dp1BkNode2 = new BookieNode(bkId2, dp1Rack);
+ networkTopology.add(dp1BkNode1);
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]