AnonHxy commented on code in PR #4119:
URL: https://github.com/apache/bookkeeper/pull/4119#discussion_r1391260053
##########
bin/bookkeeper:
##########
@@ -162,6 +162,10 @@ elif [ ${COMMAND} == "autorecovery" ]; then
exec "${JAVA}" ${OPTS} ${JMX_ARGS}
org.apache.bookkeeper.replication.AutoRecoveryMain --conf ${BOOKIE_CONF} $@
elif [ ${COMMAND} == "localbookie" ]; then
NUMBER=$1
+ if [[ ! "$NUMBER" =~ ^[0-9]+$ ]]; then
+ bookkeeper_help;
+ exit 1;
+ fi
Review Comment:
Thanks for your review @zymap
Do you mean:
```
args="$1"
shift
args="$args ${BOOKIE_CONF} $@"
exec "${JAVA}" ${OPTS} ${JMX_ARGS} -Dzookeeper.4lw.commands.whitelist='*'
org.apache.bookkeeper.util.LocalBookKeeper $args
```
I don't think this is a solution. The same problem still exists if we just
run the cmd following:
```
bin/bookkeeper localbookie
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
