This is an automated email from the ASF dual-hosted git repository.
yong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 11ccebbe60 Use Flaky flag to skip
testBookieServerZKSessionExpireBehaviour test (#4144)
11ccebbe60 is described below
commit 11ccebbe6096cfbc65fd5b1e59dce43ac013a232
Author: Hang Chen <[email protected]>
AuthorDate: Thu Dec 7 08:58:05 2023 +0800
Use Flaky flag to skip testBookieServerZKSessionExpireBehaviour test (#4144)
### Motivation
The `BookieZKExpireTest.testBookieServerZKSessionExpireBehaviour` is a
flaky test and the root cause is described in
https://github.com/apache/bookkeeper/pull/3418.
There is a race condition in the zookeeper reconnection and listener and it
is an expected behavior in Bookie.
We created one issue to track this
https://github.com/apache/bookkeeper/issues/4142.
We can skip this flaky test to unblock the pending PRs.
---
.../src/test/java/org/apache/bookkeeper/test/BookieZKExpireTest.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
a/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieZKExpireTest.java
b/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieZKExpireTest.java
index 8713756eda..808b7e8f90 100644
---
a/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieZKExpireTest.java
+++
b/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieZKExpireTest.java
@@ -32,6 +32,7 @@ import java.util.HashSet;
import lombok.extern.slf4j.Slf4j;
import org.apache.bookkeeper.bookie.MockUncleanShutdownDetection;
import org.apache.bookkeeper.bookie.TestBookieImpl;
+import org.apache.bookkeeper.common.testing.annotations.FlakyTest;
import org.apache.bookkeeper.conf.ServerConfiguration;
import org.apache.bookkeeper.proto.BookieServer;
import org.apache.bookkeeper.stats.NullStatsLogger;
@@ -121,7 +122,7 @@ public class BookieZKExpireTest extends
BookKeeperClusterTestCase {
Attempt to reconnect by BookieStateManager's RegistrationManager listener
will fail (even if retry it many times).
*/
- @Test
+ @FlakyTest(value = "https://github.com/apache/bookkeeper/issues/4142";)
@SuppressWarnings("deprecation")
public void testBookieServerZKSessionExpireBehaviour() throws Exception {
// 6000 is minimum due to default tick time
