horizonzy commented on code in PR #4122:
URL: https://github.com/apache/bookkeeper/pull/4122#discussion_r1429726177
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RegionAwareEnsemblePlacementPolicy.java:
##########
@@ -134,7 +134,8 @@ public void handleBookiesThatJoined(Set<BookieId>
joinedBookies) {
topology.add(node);
knownBookies.put(addr, node);
historyBookies.put(addr, node);
- String region = getLocalRegion(node);
+ String region = parseBookieRegion(addr);
Review Comment:
Shall we update the `address2Region` in the `onBookieRackChange`.
Even if the bookie already has been shutdown, we can still update the
`address2Region` in the `onBookieRackChange`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
