hangc0276 commented on code in PR #4081:
URL: https://github.com/apache/bookkeeper/pull/4081#discussion_r1444163249
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java:
##########
@@ -620,7 +622,7 @@ public void shutdown() {
LOG.info("Shutting down auditor");
executor.shutdown();
try {
- while (!executor.awaitTermination(30, TimeUnit.SECONDS)) {
+ while (!executor.awaitTermination(awaitTermination,
TimeUnit.SECONDS)) {
Review Comment:
It will wait at most 30s before enter the shutdownNow logic, not wait at
least 30s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
