This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new c40f756d1a rebase (#4146)
c40f756d1a is described below

commit c40f756d1af87a5b4e7b20a9ea0f70c8d40b3f72
Author: houxiaoyu <[email protected]>
AuthorDate: Tue Jan 9 13:50:53 2024 +0800

    rebase (#4146)
---
 .../java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java | 11 -----------
 1 file changed, 11 deletions(-)

diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java
 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java
index 4d43d2ebbb..d02ede52fb 100644
--- 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java
@@ -255,8 +255,6 @@ public class DefaultEntryLogger implements EntryLogger {
      * </pre>
      */
     static final int LOGFILE_HEADER_SIZE = 1024;
-    final ByteBuf logfileHeader = Unpooled.buffer(LOGFILE_HEADER_SIZE);
-
     static final int HEADER_VERSION_POSITION = 4;
     static final int LEDGERS_MAP_OFFSET_POSITION = HEADER_VERSION_POSITION + 4;
 
@@ -328,15 +326,6 @@ public class DefaultEntryLogger implements EntryLogger {
             addListener(listener);
         }
 
-        // Initialize the entry log header buffer. This cannot be a static 
object
-        // since in our unit tests, we run multiple Bookies and thus 
EntryLoggers
-        // within the same JVM. All of these Bookie instances access this 
header
-        // so there can be race conditions when entry logs are rolled over and
-        // this header buffer is cleared before writing it into the new 
logChannel.
-        logfileHeader.writeBytes("BKLO".getBytes(UTF_8));
-        logfileHeader.writeInt(HEADER_CURRENT_VERSION);
-        logfileHeader.writerIndex(LOGFILE_HEADER_SIZE);
-
         // Find the largest logId
         long logId = INVALID_LID;
         for (File dir : ledgerDirsManager.getAllLedgerDirs()) {

Reply via email to