hangc0276 commented on code in PR #4188:
URL: https://github.com/apache/bookkeeper/pull/4188#discussion_r1466628859
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java:
##########
@@ -562,6 +562,10 @@ class BatchedReadResponse extends Response implements
ReferenceCounted {
final long requestId;
final ByteBufList data;
+ BatchedReadResponse(byte protocolVersion, int errorCode, long
ledgerId, long entryId, long requestId) {
+ this(protocolVersion, errorCode, ledgerId, entryId, requestId,
ByteBufList.get());
Review Comment:
Reminder: No matter what the error code is, don't forget to release the
ByteBufList in the client side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
