lhotari commented on PR #4196: URL: https://github.com/apache/bookkeeper/pull/4196#issuecomment-1925910122
I have significantly improvement this PR. I hope to finally receive review feedback about the code in this PR. Please review @dlg99 @eolivelli @merlimat @hangc0276 @BewareMyPower . Thanks! As a reminder, there's a test that reproduces a problem with unwrapping and the checksum calculation. That is the very first commit in this PR, it is https://github.com/apache/bookkeeper/pull/4196/commits/9fb47f5dcf3848320991c7a2cf602eb325893a42 . Here's one way to reproduce on the command line: ``` gh pr checkout 4196 git checkout 9fb47f5d mvn clean install -DskipTests mvn -pl bookkeeper-server test -Dtest=CompositeByteBufUnwrapBugReproduceTest ``` Besides fixing problems, this PR will also improve performance across all checksum algorithms since input ByteBufs will be processed in most optimal ways across all implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
