lhotari commented on PR #4194: URL: https://github.com/apache/bookkeeper/pull/4194#issuecomment-1940628279
Great work @shustsud . I hope @graysonzeng could also review this PR. Perhaps not directly related to this issue, but what's your thoughts on the logic in sendAddSuccessCallbacks: https://github.com/apache/bookkeeper/blob/13e7efaa971cd3613b065ac50836c5ee98985d13/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java#L1822-L1829 Why does that logic exist in the first place? Are entry ids guaranteed to be continuous? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
