lhotari commented on code in PR #4269:
URL: https://github.com/apache/bookkeeper/pull/4269#discussion_r1557198717
##########
pom.xml:
##########
@@ -147,8 +150,6 @@
<junit.version>4.13.2</junit.version>
<hamcrest.version>1.3</hamcrest.version>
<junit5.version>5.10.2</junit5.version>
- <assertj-core.version>3.25.3</assertj-core.version>
- <awaitility.version>4.2.0</awaitility.version>
Review Comment:
I'd suggest to not move these in the same PR. If there's a need to put these
in alphabetical order, it's better to do that separately and do it
consistently. Currently the testing related libraries are kept together and
that's why assertj-core and awaitility versions are after junit5 version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
