eolivelli commented on code in PR #4288:
URL: https://github.com/apache/bookkeeper/pull/4288#discussion_r1568224474


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java:
##########
@@ -1098,7 +1098,7 @@ public int getAllocatorPoolingConcurrency() {
      *            the concurrency level to use for the allocator pool
      * @return configuration object.
      */
-    public T setAllocatorPoolingConcurrenncy(int concurrency) {
+    public T setAllocatorPoolingConcurrency(int concurrency) {

Review Comment:
   This is a public API change and it will break users.
   
   In order to fix this property we have to:
   - add the new method
   - mark the existing method as Deprecated
   - wait for a minor (4.18) version release
   -  send a new a patch that removes the method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to