eolivelli commented on code in PR #3886:
URL: https://github.com/apache/bookkeeper/pull/3886#discussion_r1588877880
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtoEncoding.java:
##########
@@ -215,6 +215,14 @@ private static byte[] readMasterKey(ByteBuf packet) {
return masterKey;
}
+
+ public static void serializeAddRequests(Object request, ByteBufList
buf) {
+ if (request instanceof ByteBuf) {
+ buf.add((ByteBuf) request);
+ } else if (request instanceof ByteBufList) {
+ buf.add((ByteBufList) request);
+ }
Review Comment:
else throw IllegalStateException ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
