shoothzj commented on code in PR #4340:
URL: https://github.com/apache/bookkeeper/pull/4340#discussion_r1590666985
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java:
##########
@@ -192,7 +192,6 @@ private JournalChannel(File journalDirectory, long logId,
writeHeader(bcBuilder, writeBufferSize);
} else { // open an existing file to read.
fc = channel.getFileChannel();
- bc = null; // readonly
Review Comment:
@eolivelli I think it's impossible unless we use Optional. And I think it
will not be better to use Optional here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
