This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 1ae4be04e2 Use slf4j-bom and log4j-bom in dependencyManagement (#4346)
1ae4be04e2 is described below
commit 1ae4be04e20eca4490b52da474d455a2414168b4
Author: Lari Hotari <[email protected]>
AuthorDate: Tue May 7 02:46:57 2024 +0300
Use slf4j-bom and log4j-bom in dependencyManagement (#4346)
### Motivation
When using SLF4J 2.0.x, it's useful to use slf4j-bom to align slf4j library
versions. This is necessary to ensure that logging doesn't break due to mixed
slf4j library versions.
Similarly, it's useful to use log4j-bom to align log4j library versions.
SLF4J 2.0.x upgrade was made in PR #4248 .
### Changes
- use slf4j-bom and log4j-bom in dependencyManagement
---
pom.xml | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/pom.xml b/pom.xml
index 5440051ab2..bd6db15166 100644
--- a/pom.xml
+++ b/pom.xml
@@ -242,18 +242,17 @@
<!-- logging dependencies -->
<dependency>
<groupId>org.slf4j</groupId>
- <artifactId>slf4j-api</artifactId>
+ <artifactId>slf4j-bom</artifactId>
<version>${slf4j.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
- <artifactId>log4j-core</artifactId>
- <version>${log4j.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.logging.log4j</groupId>
- <artifactId>log4j-slf4j2-impl</artifactId>
+ <artifactId>log4j-bom</artifactId>
<version>${log4j.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
</dependency>
<dependency>
<groupId>com.lmax</groupId>
