yaalsn commented on PR #4361: URL: https://github.com/apache/bookkeeper/pull/4361#issuecomment-2106416817
> Is this change exposing secrets to github users? > If this change add security risky for the community I suggest to push this change only to your repo @eolivelli No, it doesn't expose secret to anyone or add secrity risky, because the github action `apache/pulsar-test-infra/paths-filter@master` is reliable. Instead, it add the safety. This is a github security setting. We should declare the workflow job permission, this makes the ones who forked repo know which permissions it uses instead of a black box. `apache/bookkeeper` just uses the default non-security strategy, this means the PRs github action can do anything using `GITHUB_TOKEN` after the PR is approved to run, but the reviewers don't know the action does clearly. docs: * https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
