TakaHiR07 commented on PR #4374: URL: https://github.com/apache/bookkeeper/pull/4374#issuecomment-2123771410
> Nice catch. > > I think we can change `createSingleThreadExecutor` return SingleThreadExecutor directly. BTW, I prefer split this pr, one to fix problem, one to modify the metric name. ok, I would split to 2 pr. But I guess we can't change `createSingleThreadExecutor` return SingleThreadExecutor directly, because OrderedScheduler#createSingleThreadExecutor do not return SingleThreadExecutor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@bookkeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
