This is an automated email from the ASF dual-hosted git repository.

shoothzj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 94956e039f tests: close bookkeeper client in 
testSequenceReadLocalEnsemble (#4416)
94956e039f is described below

commit 94956e039f1ca24121fa2ca8deb4fc14c826e986
Author: ZhangJian He <[email protected]>
AuthorDate: Mon Jun 3 11:12:16 2024 +0800

    tests: close bookkeeper client in testSequenceReadLocalEnsemble (#4416)
    
    Signed-off-by: ZhangJian He <[email protected]>
---
 .../org/apache/bookkeeper/client/TestSpeculativeRead.java   | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git 
a/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestSpeculativeRead.java
 
b/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestSpeculativeRead.java
index 177f85a00b..a1b29ece13 100644
--- 
a/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestSpeculativeRead.java
+++ 
b/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestSpeculativeRead.java
@@ -393,11 +393,12 @@ public class TestSpeculativeRead extends 
BookKeeperClusterTestCase {
                 .setReorderReadSequenceEnabled(true)
                 .setEnsemblePlacementPolicySlowBookies(true)
                 .setMetadataServiceUri(zkUtil.getMetadataServiceUri());
-        BookKeeper bkspec = new BookKeeperTestClient(conf, new 
TestStatsProvider());
-        LedgerHandle l = bkspec.createLedger(1, 1, digestType, passwd);
-        List<BookieId> ensemble = 
l.getLedgerMetadata().getAllEnsembles().get(0L);
-        PendingReadOp op = new PendingReadOp(l, bkspec.getClientCtx(), 0, 5, 
false);
-        PendingReadOp.LedgerEntryRequest req0 = op.new 
SequenceReadRequest(ensemble, l.getId(), 0);
-        assertNotNull(req0.writeSet);
+        try (BookKeeper bkc = new BookKeeperTestClient(conf, new 
TestStatsProvider())) {
+            LedgerHandle l = bkc.createLedger(1, 1, digestType, passwd);
+            List<BookieId> ensemble = 
l.getLedgerMetadata().getAllEnsembles().get(0L);
+            PendingReadOp op = new PendingReadOp(l, bkc.getClientCtx(), 0, 5, 
false);
+            PendingReadOp.LedgerEntryRequest req0 = op.new 
SequenceReadRequest(ensemble, l.getId(), 0);
+            assertNotNull(req0.writeSet);
+        }
     }
 }

Reply via email to