dlg99 commented on code in PR #4425:
URL: https://github.com/apache/bookkeeper/pull/4425#discussion_r1632380023
##########
bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/OrderedExecutor.java:
##########
@@ -187,10 +187,14 @@ public T build() {
protected class TimedRunnable implements Runnable {
final Runnable runnable;
final long initNanos;
+ final String runnableString;
+ final Class<?> runnableClass;
TimedRunnable(Runnable runnable) {
this.runnable = runnable;
this.initNanos = MathUtils.nowInNano();
+ this.runnableString = runnable.toString();
Review Comment:
toString() can be expensive; maybe skip this and only log the class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
