poorbarcode commented on code in PR #4462:
URL: https://github.com/apache/bookkeeper/pull/4462#discussion_r1673996453
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java:
##########
@@ -87,6 +94,61 @@ public void testBasicFencing() throws Exception {
readlh.getLastAddConfirmed() ==
writelh.getLastAddConfirmed());
}
+ @Test
+ public void testWriteAfterDeleted() throws Exception {
+ LedgerHandle writeLedger;
+ writeLedger = bkc.createLedger(digestType, "password".getBytes());
+
+ String tmp = "BookKeeper is cool!";
+ for (int i = 0; i < 10; i++) {
+ long entryId = writeLedger.addEntry(tmp.getBytes());
+ LOG.info("entryId: {}", entryId);
+ }
+
+ // Fence and delete.
+ BookKeeperTestClient bkc2 = new BookKeeperTestClient(baseClientConf,
new TestStatsProvider());
+ LedgerHandle readLedger = bkc2.openLedger(writeLedger.getId(),
digestType, "password".getBytes());
+ bkc2.deleteLedger(readLedger.ledgerId);
+
+ // Waiting for GC.
+ for (ServerTester server : servers) {
+ triggerGC(server.getServer().getBookie());
+ }
+
+ try {
+ long entryId = writeLedger.addEntry(tmp.getBytes());
+ LOG.info("Not expected: entryId: {}", entryId);
+ LOG.error("Should have thrown an exception");
+ fail("Should have thrown an exception when trying to write");
+ } catch (Exception e) {
+ e.printStackTrace();
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
