AuroraTwinkle commented on code in PR #4466:
URL: https://github.com/apache/bookkeeper/pull/4466#discussion_r1718056226


##########
conf/entry_location_rocksdb.conf.default:
##########
@@ -26,7 +30,7 @@
  # set by jni: options.setLogFileTimeToRoll
  log_file_time_to_roll=86400
  # set by jni: options.setMaxBackgroundJobs or options.setIncreaseParallelism
- max_background_jobs=2
+ max_background_jobs=32

Review Comment:
   > What's the rationale in making this change in this PR?
   
   Hi Lari:
   The previous default value for **max_background_jobs** was written 
incorrectly and was not consistent with the default value in the code, so this 
PR corrected it. Refer to: 
https://github.com/apache/bookkeeper/blob/999cd0f2ab14404be4d6c24e388456dbe56bb1a8/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageRocksDB.java#L213
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to