ange-k commented on PR #4478: URL: https://github.com/apache/bookkeeper/pull/4478#issuecomment-2295284742
> +1 > > > > Out of curiosity, how big is your "ensemble" ? I am used to values from 3 to 7, and with those numbers this patch is not a big deal Thank you for your feedback. In our environment, the ensemble size is set to 6, and the WriteSet size is 2. As you pointed out, we also recognize that the performance improvement from this code change may be minimal. Nevertheless, I found the unnecessary sorting to be somewhat inefficient. While it may not have a significant impact, I felt it was worth addressing for code cleanliness, which led me to submit this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
