lhotari commented on code in PR #4464: URL: https://github.com/apache/bookkeeper/pull/4464#discussion_r1726679478
########## docker/Dockerfile: ########## @@ -86,6 +86,13 @@ COPY --from=jre-build /javaruntime $JAVA_HOME COPY scripts /opt/bookkeeper/scripts RUN chmod +x -R /opt/bookkeeper/scripts/ +RUN chown -R 10000:0 /opt/bookkeeper +RUN chmod -R ug+rwx /opt/bookkeeper +RUN chmod -R g+rx /opt/bookkeeper/bin +RUN chmod -R g+rx /opt/bookkeeper/scripts Review Comment: I think that this could potentially increase the size of the docker image. That's why a multi-stage docker image is recommended where the bits are set in one stage and copied from the intermediate image in the final stage. For example this is what is done in Pulsar: https://github.com/apache/pulsar/blob/0a5cb51a2f010d6771ae0ae0fd259d002cca20da/docker/pulsar/Dockerfile#L138 . You could check the Dockerfile from branch-3.2 to see an Ubuntu example: https://github.com/apache/pulsar/blob/f7c540e79873dff6dc447dcc0f3b814000743ec3/docker/pulsar/Dockerfile#L20-L48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
