liangyepianzhou opened a new pull request, #4520:
URL: https://github.com/apache/bookkeeper/pull/4520

   ### Motivation
   The https://github.com/apache/bookkeeper/pull/3212  import a feature: 
convert bookie to read-only mode when any ledger disks is full. 
   In our practice, we found that when the bookie disk is full, if it is not 
changed to Read Only mode, a large number of messages will fail to be written 
to the ledger disk. And because the bookie status is still available at this 
time, no alarm is given to the maintenance personnel, resulting in slow access 
for the maintenance personnel.
   
   That feature is safe and has been in place for some time. I think we should 
try to change its default value.
   
   PS: It was mentioned in the PR discussion that an email discussion should be 
submitted, but no follow-up was done. [0]
   [0] - https://github.com/apache/bookkeeper/pull/3212/files#r857122376
   
   ### Changes
   
   (Describe: what changes you have made)
   
   > ---
   > In order to uphold a high standard for quality for code contributions, 
Apache BookKeeper runs various precommit
   > checks for pull requests. A pull request can only be merged when it passes 
precommit checks.
   >
   > ---
   > Be sure to do all the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue #>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install 
spotbugs:check`.
   > - [ ] Replace `<Issue #>` in the title with the actual Issue number.
   > 
   > ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to