AnonHxy commented on code in PR #4525:
URL: https://github.com/apache/bookkeeper/pull/4525#discussion_r1843906586
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/LedgerMetadataIndex.java:
##########
@@ -345,6 +345,7 @@ public void removeDeletedLedgers() throws IOException {
log.debug("Persisting deletes of ledgers {}", deletedLedgers);
}
+ pendingDeletedLedgers.clear();
Review Comment:
Thanks for your fix. But I think we should call
`pendingDeletedLedgers.remove(ledgerId)` after line342.
`pendingDeletedLedgers` cloud being adding when call `clear()`, cause some
ledgers not have deleted form ledgersDB but clear from `pendingDeletedLedgers
`.
By the way. `pendingDeletedLedgers ` is a `Sets.newConcurrentHashSet()`.
I think it will not concurrent error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
