hezhangjian commented on code in PR #4507:
URL: https://github.com/apache/bookkeeper/pull/4507#discussion_r1957521910
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookKeeperServerStats.java:
##########
@@ -146,6 +146,7 @@ public interface BookKeeperServerStats {
// Compaction/Garbage Collection Related Counters
String ACTIVE_ENTRY_LOG_COUNT = "ACTIVE_ENTRY_LOG_TOTAL";
String ACTIVE_ENTRY_LOG_SPACE_BYTES = "ACTIVE_ENTRY_LOG_SPACE_BYTES";
+ String TOTAL_ENTRY_LOG_SPACE_BYTES = "TOTAL_ENTRY_LOG_SPACE_BYTES";
Review Comment:
I am a little hesitated, I perfer to remove `TOTAL_` perfix, it's common
appear as suffix to indicate it's type. Put it in front doesn't bring
additional information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
