nodece commented on code in PR #4488:
URL: https://github.com/apache/bookkeeper/pull/4488#discussion_r2052048865
##########
bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/SingleThreadExecutor.java:
##########
@@ -204,27 +216,89 @@ public long getFailedTasksCount() {
@Override
public void execute(Runnable r) {
+ executeRunnableOrList(r, null);
Review Comment:
@xiezhx9 `toList()` is an expensive operation and should be avoided in
performance-critical paths, `executeRunnableOrList()` is used only for testing
purposes, so this usage is acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
