This is an automated email from the ASF dual-hosted git repository.
hezhangjian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 22c45f925a Delete outdated TODO for Issue #458 (#4601)
22c45f925a is described below
commit 22c45f925a174be3fde0c4ce86923a3751a54cc8
Author: Xiangying Meng <55571188+liangyepianz...@users.noreply.github.com>
AuthorDate: Tue May 6 16:58:21 2025 +0800
Delete outdated TODO for Issue #458 (#4601)
Co-authored-by: xiangying <mengxiangy...@xiaohongshu.com>
---
deploy/kubernetes/gke/bookkeeper.statefulset.yml | 1 -
deploy/kubernetes/gke/bookkeeper.yaml | 1 -
2 files changed, 2 deletions(-)
diff --git a/deploy/kubernetes/gke/bookkeeper.statefulset.yml
b/deploy/kubernetes/gke/bookkeeper.statefulset.yml
index ca32b91137..1d9e4fbd09 100644
--- a/deploy/kubernetes/gke/bookkeeper.statefulset.yml
+++ b/deploy/kubernetes/gke/bookkeeper.statefulset.yml
@@ -39,7 +39,6 @@ data:
BK_ledgerDirectories: "/bookkeeper/data/ledgers"
BK_indexDirectories: "/bookkeeper/data/ledgers"
BK_zkServers: zookeeper
- # TODO: Issue 458: https://github.com/apache/bookkeeper/issues/458
#BK_statsProviderClass:
org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider
# use hostname as bookie id for StatefulSets deployment
BK_useHostNameAsBookieID: "true"
diff --git a/deploy/kubernetes/gke/bookkeeper.yaml
b/deploy/kubernetes/gke/bookkeeper.yaml
index 78b28c892a..b0f12ed384 100644
--- a/deploy/kubernetes/gke/bookkeeper.yaml
+++ b/deploy/kubernetes/gke/bookkeeper.yaml
@@ -30,7 +30,6 @@ data:
BK_ledgerDirectories: "/bookkeeper/data/ledgers"
BK_indexDirectories: "/bookkeeper/data/ledgers"
BK_zkServers: zookeeper
- # TODO: Issue 458: https://github.com/apache/bookkeeper/issues/458
#BK_statsProviderClass:
org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider
---
