zhaizhibo opened a new pull request, #4660: URL: https://github.com/apache/bookkeeper/pull/4660
fix [4651](https://github.com/apache/bookkeeper/issues/4651) ### Motivation **BUG REPORT** ``` 2025-08-01T17:09:12,274+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:12,372+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:14,914+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:15,114+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:15,940+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:16,040+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:16,103+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:16,201+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:16,258+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:16,369+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:16,427+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:16,474+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:16,573+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:16,632+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:16,677+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:16,837+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:16,913+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:16,966+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 2025-08-01T17:09:17,178+0800 [BookKeeperClientWorker-OrderedExecutor-11-0] INFO org.apache.bookkeeper.client.LedgerHandle.lambda$ensembleChangeLoop$12(LedgerHandle.java:2274) - New Ensemble: [xxx, xxx] for ledger: 1547399 ``` Scenario: e2/w2/a1 Ledger `L1` has entries `(5-10)` to write (Thread A). Initial state: `LAC=4`, ledger metadata: `{5: [BK1, BK2]}`. Steps: 1. Start writes: `5,6` send request to bk server; `7` fails (channel unwritable, queues callback). 2. `Ensemble change triggered` (since `LAC=4` matches `newEnsembleStartEntry=5`): 3. Metadata updated to `{5: [BK3, BK4]}` (callback queued). 4. `5,6` succeed, `LAC` updates to `6`, entries removed from pending queue. 5. Issue: Entries `5-6` were written to `[BK1,BK2]`, but ZK incorrectly records them as `[BK3,BK4]`. ### Changes make sure `org.apache.bookkeeper.client.LedgerHandle#sendAddSuccessCallbacks` only can be called after `unsetSuccessAndSendWriteRequest(...) completes`, which can avoid the fix incorrect meta of ledger. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
