wenbingshen commented on code in PR #4713:
URL: https://github.com/apache/bookkeeper/pull/4713#discussion_r2871204465
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingWriteLacOp.java:
##########
@@ -112,6 +113,8 @@ public void writeLacComplete(int rc, long ledgerId,
BookieId addr, Object ctx) {
if (receivedResponseSet.isEmpty()){
completed = true;
+ ReferenceCountUtil.release(toSend);
Review Comment:
@horizonzy After reviewing the implementation of `PendingWriteLacOp`, I
found that the implementation of `writeLacComplete` did not meet the
requirements of multi-threaded concurrency safety, so I revised the PR. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
