lhotari commented on code in PR #4727:
URL: https://github.com/apache/bookkeeper/pull/4727#discussion_r2958459136
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java:
##########
@@ -1456,6 +1457,28 @@ public ClientConfiguration
setBookieErrorThresholdPerInterval(long thresholdPerI
return this;
}
+
+ /**
+ * Set if count the bookie connecting error into the quarantine condition.
If this is enabled, the connection
+ * error will be counted into the BookieErrorThresholdPerInterval. So be
careful to set the quarantine time.
+ *
+ * @param enabled
+ * @return
+ */
+ public ClientConfiguration
setBookieConnectionErrorQuarantineEnabled(boolean enabled) {
+ setProperty(BOOKIE_CONNECTING_ERROR_QUARANTINE_ENABLED, enabled);
Review Comment:
```suggestion
setProperty(BOOKIE_CONNECTION_ERROR_QUARANTINE_ENABLED, enabled);
```
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java:
##########
@@ -1456,6 +1457,28 @@ public ClientConfiguration
setBookieErrorThresholdPerInterval(long thresholdPerI
return this;
}
+
+ /**
+ * Set if count the bookie connecting error into the quarantine condition.
If this is enabled, the connection
+ * error will be counted into the BookieErrorThresholdPerInterval. So be
careful to set the quarantine time.
+ *
+ * @param enabled
+ * @return
+ */
+ public ClientConfiguration
setBookieConnectionErrorQuarantineEnabled(boolean enabled) {
+ setProperty(BOOKIE_CONNECTING_ERROR_QUARANTINE_ENABLED, enabled);
+ return this;
+ }
+
+ /**
+ * Get if count the bookie connecting error into the quarantine condition.
+ *
+ * @return
+ */
+ public boolean getBookieConnectionErrorQuarantineEnabled() {
+ return getBoolean(BOOKIE_CONNECTING_ERROR_QUARANTINE_ENABLED, false);
Review Comment:
```suggestion
return getBoolean(BOOKIE_CONNECTION_ERROR_QUARANTINE_ENABLED, false);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
