merlimat commented on code in PR #4780:
URL: https://github.com/apache/bookkeeper/pull/4780#discussion_r3210002539
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadLacProcessorV3.java:
##########
@@ -66,7 +61,7 @@ private ReadLacResponse getReadLacResponse() {
try {
lac = requestProcessor.bookie.getExplicitLac(ledgerId);
if (lac != null) {
-
readLacResponse.setLacBody(ByteString.copyFrom(lac.nioBuffer()));
+ readLacResponse.setLacBody(ByteBufUtil.getBytes(lac));
Review Comment:
I wouldn't try to improve performance as part of this change, since the
retention itself can be quite tricky to track.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
