This is an automated email from the ASF dual-hosted git repository.

merlimat pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 985fe2a766 fix: add javadoc support for pom-only shaded modules (#4787)
985fe2a766 is described below

commit 985fe2a7667e13bb520a2f0096d2047dc5c7f702
Author: Zixuan Liu <[email protected]>
AuthorDate: Sun May 10 01:31:28 2026 +0800

    fix: add javadoc support for pom-only shaded modules (#4787)
---
 metadata-drivers/jetcd-core-shaded/pom.xml    | 15 +++++++++++++++
 pom.xml                                       | 13 +++----------
 shaded/bookkeeper-server-shaded/pom.xml       | 15 +++++++++++++++
 shaded/bookkeeper-server-tests-shaded/pom.xml | 15 +++++++++++++++
 shaded/distributedlog-core-shaded/pom.xml     | 15 +++++++++++++++
 5 files changed, 63 insertions(+), 10 deletions(-)

diff --git a/metadata-drivers/jetcd-core-shaded/pom.xml 
b/metadata-drivers/jetcd-core-shaded/pom.xml
index 0fbbbcabd7..bb4f23ce28 100644
--- a/metadata-drivers/jetcd-core-shaded/pom.xml
+++ b/metadata-drivers/jetcd-core-shaded/pom.xml
@@ -147,6 +147,21 @@
           <skip>true</skip>
         </configuration>
       </plugin>
+      <plugin>
+        <artifactId>maven-jar-plugin</artifactId>
+        <executions>
+          <execution>
+            <id>javadoc-jar</id>
+            <phase>package</phase>
+            <goals>
+              <goal>jar</goal>
+            </goals>
+            <configuration>
+              <classifier>javadoc</classifier>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
     </plugins>
   </build>
 </project>
diff --git a/pom.xml b/pom.xml
index 3a9f2a9af1..cbe4db6875 100644
--- a/pom.xml
+++ b/pom.xml
@@ -236,6 +236,8 @@
     <okio.version>3.16.3</okio.version>
     <UBUNTU_MIRROR>http://archive.ubuntu.com/ubuntu/</UBUNTU_MIRROR>
     
<UBUNTU_SECURITY_MIRROR>http://security.ubuntu.com/ubuntu/</UBUNTU_SECURITY_MIRROR>
+    <!-- skip javadoc generation by default, use -Pdelombok to activate -->
+    <maven.javadoc.skip>true</maven.javadoc.skip>
   </properties>
 
   <!-- dependency definitions -->
@@ -1027,8 +1029,6 @@
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-javadoc-plugin</artifactId>
           <configuration>
-            <!-- skip javadoc generation by default, use -Pdelombok to 
activate -->
-            <skip>true</skip>
             <doclint>none</doclint>
           </configuration>
         </plugin>
@@ -1320,6 +1320,7 @@
       <id>delombok</id>
       <properties>
         
<src.dir>${project.build.directory}/generated-sources/delombok</src.dir>
+        <maven.javadoc.skip>false</maven.javadoc.skip>
       </properties>
       <build>
         <plugins>
@@ -1351,14 +1352,6 @@
               </execution>
             </executions>
           </plugin>
-          <plugin>
-            <groupId>org.apache.maven.plugins</groupId>
-            <artifactId>maven-javadoc-plugin</artifactId>
-            <configuration>
-              <!-- activate javadoc generation -->
-              <skip>false</skip>
-            </configuration>
-          </plugin>
         </plugins>
       </build>
     </profile>
diff --git a/shaded/bookkeeper-server-shaded/pom.xml 
b/shaded/bookkeeper-server-shaded/pom.xml
index b390ee0e7e..987f044470 100644
--- a/shaded/bookkeeper-server-shaded/pom.xml
+++ b/shaded/bookkeeper-server-shaded/pom.xml
@@ -131,6 +131,21 @@
           </filesets>
         </configuration>
       </plugin>
+      <plugin>
+        <artifactId>maven-jar-plugin</artifactId>
+        <executions>
+          <execution>
+            <id>javadoc-jar</id>
+            <phase>package</phase>
+            <goals>
+              <goal>jar</goal>
+            </goals>
+            <configuration>
+              <classifier>javadoc</classifier>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
     </plugins>
   </build>
 </project>
diff --git a/shaded/bookkeeper-server-tests-shaded/pom.xml 
b/shaded/bookkeeper-server-tests-shaded/pom.xml
index 29b3444fd5..4c92406141 100644
--- a/shaded/bookkeeper-server-tests-shaded/pom.xml
+++ b/shaded/bookkeeper-server-tests-shaded/pom.xml
@@ -148,6 +148,21 @@
           </filesets>
         </configuration>
       </plugin>
+      <plugin>
+        <artifactId>maven-jar-plugin</artifactId>
+        <executions>
+          <execution>
+            <id>javadoc-jar</id>
+            <phase>package</phase>
+            <goals>
+              <goal>jar</goal>
+            </goals>
+            <configuration>
+              <classifier>javadoc</classifier>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
     </plugins>
   </build>
 </project>
diff --git a/shaded/distributedlog-core-shaded/pom.xml 
b/shaded/distributedlog-core-shaded/pom.xml
index bbdb92cfba..e066067fb0 100644
--- a/shaded/distributedlog-core-shaded/pom.xml
+++ b/shaded/distributedlog-core-shaded/pom.xml
@@ -232,6 +232,21 @@
           </filesets>
         </configuration>
       </plugin>
+      <plugin>
+        <artifactId>maven-jar-plugin</artifactId>
+        <executions>
+          <execution>
+            <id>javadoc-jar</id>
+            <phase>package</phase>
+            <goals>
+              <goal>jar</goal>
+            </goals>
+            <configuration>
+              <classifier>javadoc</classifier>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
     </plugins>
   </build>
 </project>

Reply via email to