nodece opened a new pull request, #4815:
URL: https://github.com/apache/bookkeeper/pull/4815
## Summary
When `BookieImpl.start()` fails during journal replay (e.g. missing recovery
log), the exception is silently swallowed and the bookie appears to be running
despite being in a broken, partially-initialized state.
**Root cause:** Two issues conspire to hide the failure:
1. **`BookieServer.start()`** detects `!bookie.isRunning()` but silently
`return`s instead of throwing an exception. The method declares `throws
IOException` but never uses it on the failure path.
2. **`BookieImpl.shutdown()`** skips setting `this.exitCode` when
`isRunning()` is `false` (which is always the case before `initState()` is
called at line 756). So `getExitCode()` returns `ExitCode.OK` (0) even on
failure.
**Effect:** The exception is caught by `AbstractLifecycleComponent.start()`
and dispatched to the `uncaughtExceptionHandler` (set by `ComponentStarter`),
which triggers `ComponentShutdownHook` for cleanup. However, without the
IOException being thrown from `BookieServer.start()`, the exception path relies
entirely on the handler — and the exit code was incorrectly `OK(0)`.
## Changes
- **`BookieServer.start()`**: `return` → `throw new IOException("Bookie
failed to start, exit code: " + exitCode)` — ensures the exception properly
propagates to the lifecycle framework's exception handler.
- **`BookieImpl.shutdown()`**: Move `this.exitCode = exitCode` outside the
`if (isRunning())` guard — ensures the exit code is always set, even during
early startup before `initState()`.
Complementary to #4740 which fixed the root cause of journal file deletion
(lastMark regression). This PR fixes the consequence: if a journal file is
missing for any reason, the bookie should fail fast with a proper error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
