kroosxu commented on code in PR #4798:
URL: https://github.com/apache/bookkeeper/pull/4798#discussion_r3681266606
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java:
##########
@@ -459,9 +459,11 @@ public BookKeeper(ClientConfiguration conf, ZooKeeper zk,
EventLoopGroup eventLo
log.error()
.exception(ce)
.log("Failed to initialize metadata client driver using
invalid metadata service uri");
+ close();
Review Comment:
Good point — done.use Try-finally to handle the close.most of the diff is
pure whitespace.please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
