Copilot commented on code in PR #4871: URL: https://github.com/apache/bookkeeper/pull/4871#discussion_r3974644516
########## bookkeeper-dist/src/main/resources/LICENSE-server.bin.txt: ########## @@ -267,15 +267,15 @@ Apache Software License, Version 2. - lib/org.apache.zookeeper-zookeeper-3.9.5.jar [21] - lib/org.apache.zookeeper-zookeeper-jute-3.9.5.jar [21] - lib/org.apache.zookeeper-zookeeper-3.9.5-tests.jar [21] -- lib/org.eclipse.jetty-jetty-http-12.1.7.jar [22] -- lib/org.eclipse.jetty-jetty-io-12.1.7.jar [22] -- lib/org.eclipse.jetty-jetty-security-12.1.7.jar [22] -- lib/org.eclipse.jetty-jetty-server-12.1.7.jar [22] -- lib/org.eclipse.jetty-jetty-session-12.1.7.jar [22] -- lib/org.eclipse.jetty-jetty-util-12.1.7.jar [22] -- lib/org.eclipse.jetty.ee8-jetty-ee8-nested-12.1.7.jar [22] -- lib/org.eclipse.jetty.ee8-jetty-ee8-security-12.1.7.jar [22] -- lib/org.eclipse.jetty.ee8-jetty-ee8-servlet-12.1.7.jar [22] +- lib/org.eclipse.jetty-jetty-http-12.1.10.jar [22] +- lib/org.eclipse.jetty-jetty-io-12.1.10.jar [22] +- lib/org.eclipse.jetty-jetty-security-12.1.10.jar [22] +- lib/org.eclipse.jetty-jetty-server-12.1.10.jar [22] +- lib/org.eclipse.jetty-jetty-session-12.1.10.jar [22] +- lib/org.eclipse.jetty-jetty-util-12.1.10.jar [22] +- lib/org.eclipse.jetty.ee8-jetty-ee8-nested-12.1.10.jar [22] +- lib/org.eclipse.jetty.ee8-jetty-ee8-security-12.1.10.jar [22] +- lib/org.eclipse.jetty.ee8-jetty-ee8-servlet-12.1.10.jar [22] - lib/org.eclipse.jetty.toolchain-jetty-servlet-api-4.0.9.jar [22] Review Comment: The Jetty LICENSE entries also appear to have dropped the leading indentation present in the previous version of the list. Restoring the original indentation would keep formatting consistent with the surrounding entries and reduce unnecessary whitespace-only changes. ########## bookkeeper-dist/src/main/resources/LICENSE-all.bin.txt: ########## @@ -267,15 +267,15 @@ Apache Software License, Version 2. - lib/org.apache.zookeeper-zookeeper-3.9.5.jar [21] - lib/org.apache.zookeeper-zookeeper-jute-3.9.5.jar [21] - lib/org.apache.zookeeper-zookeeper-3.9.5-tests.jar [21] -- lib/org.eclipse.jetty-jetty-http-12.1.7.jar [22] -- lib/org.eclipse.jetty-jetty-io-12.1.7.jar [22] -- lib/org.eclipse.jetty-jetty-security-12.1.7.jar [22] -- lib/org.eclipse.jetty-jetty-server-12.1.7.jar [22] -- lib/org.eclipse.jetty-jetty-session-12.1.7.jar [22] -- lib/org.eclipse.jetty-jetty-util-12.1.7.jar [22] -- lib/org.eclipse.jetty.ee8-jetty-ee8-nested-12.1.7.jar [22] -- lib/org.eclipse.jetty.ee8-jetty-ee8-security-12.1.7.jar [22] -- lib/org.eclipse.jetty.ee8-jetty-ee8-servlet-12.1.7.jar [22] +- lib/org.eclipse.jetty-jetty-http-12.1.10.jar [22] +- lib/org.eclipse.jetty-jetty-io-12.1.10.jar [22] +- lib/org.eclipse.jetty-jetty-security-12.1.10.jar [22] +- lib/org.eclipse.jetty-jetty-server-12.1.10.jar [22] +- lib/org.eclipse.jetty-jetty-session-12.1.10.jar [22] +- lib/org.eclipse.jetty-jetty-util-12.1.10.jar [22] +- lib/org.eclipse.jetty.ee8-jetty-ee8-nested-12.1.10.jar [22] +- lib/org.eclipse.jetty.ee8-jetty-ee8-security-12.1.10.jar [22] +- lib/org.eclipse.jetty.ee8-jetty-ee8-servlet-12.1.10.jar [22] Review Comment: Same formatting concern as `LICENSE-server.bin.txt`: the updated entries appear unindented compared to prior formatting. Recommend keeping indentation consistent across the manifest for readability and to avoid whitespace churn. ########## bookkeeper-dist/src/main/resources/NOTICE-server.bin.txt: ########## @@ -77,15 +77,15 @@ SoundCloud Ltd. (http://soundcloud.com/). This product includes software developed as part of the Ocelli project by Netflix Inc. (https://github.com/Netflix/ocelli/). ------------------------------------------------------------------------------------ -- lib/org.eclipse.jetty-jetty-http-12.1.7.jar -- lib/org.eclipse.jetty-jetty-io-12.1.7.jar -- lib/org.eclipse.jetty-jetty-security-12.1.7.jar -- lib/org.eclipse.jetty-jetty-server-12.1.7.jar -- lib/org.eclipse.jetty-jetty-session-12.1.7.jar -- lib/org.eclipse.jetty-jetty-util-12.1.7.jar -- lib/org.eclipse.jetty.ee8-jetty-ee8-nested-12.1.7.jar -- lib/org.eclipse.jetty.ee8-jetty-ee8-security-12.1.7.jar -- lib/org.eclipse.jetty.ee8-jetty-ee8-servlet-12.1.7.jar +- lib/org.eclipse.jetty-jetty-http-12.1.10.jar +- lib/org.eclipse.jetty-jetty-io-12.1.10.jar +- lib/org.eclipse.jetty-jetty-security-12.1.10.jar +- lib/org.eclipse.jetty-jetty-server-12.1.10.jar +- lib/org.eclipse.jetty-jetty-session-12.1.10.jar +- lib/org.eclipse.jetty-jetty-util-12.1.10.jar +- lib/org.eclipse.jetty.ee8-jetty-ee8-nested-12.1.10.jar +- lib/org.eclipse.jetty.ee8-jetty-ee8-security-12.1.10.jar +- lib/org.eclipse.jetty.ee8-jetty-ee8-servlet-12.1.10.jar Review Comment: These updated Jetty entries appear to have lost the leading indentation that was present on the previous lines (e.g., ` |- ...`). For readability and to minimize diffs (and any potential tooling assumptions about formatting), keep the indentation consistent with the surrounding list formatting. ########## bookkeeper-dist/src/main/resources/NOTICE-all.bin.txt: ########## @@ -95,15 +95,15 @@ SoundCloud Ltd. (http://soundcloud.com/). This product includes software developed as part of the Ocelli project by Netflix Inc. (https://github.com/Netflix/ocelli/). ------------------------------------------------------------------------------------ -- lib/org.eclipse.jetty-jetty-http-12.1.7.jar -- lib/org.eclipse.jetty-jetty-io-12.1.7.jar -- lib/org.eclipse.jetty-jetty-security-12.1.7.jar -- lib/org.eclipse.jetty-jetty-server-12.1.7.jar -- lib/org.eclipse.jetty-jetty-session-12.1.7.jar -- lib/org.eclipse.jetty-jetty-util-12.1.7.jar -- lib/org.eclipse.jetty.ee8-jetty-ee8-nested-12.1.7.jar -- lib/org.eclipse.jetty.ee8-jetty-ee8-security-12.1.7.jar -- lib/org.eclipse.jetty.ee8-jetty-ee8-servlet-12.1.7.jar +- lib/org.eclipse.jetty-jetty-http-12.1.10.jar +- lib/org.eclipse.jetty-jetty-io-12.1.10.jar +- lib/org.eclipse.jetty-jetty-security-12.1.10.jar +- lib/org.eclipse.jetty-jetty-server-12.1.10.jar +- lib/org.eclipse.jetty-jetty-session-12.1.10.jar +- lib/org.eclipse.jetty-jetty-util-12.1.10.jar +- lib/org.eclipse.jetty.ee8-jetty-ee8-nested-12.1.10.jar +- lib/org.eclipse.jetty.ee8-jetty-ee8-security-12.1.10.jar +- lib/org.eclipse.jetty.ee8-jetty-ee8-servlet-12.1.10.jar - lib/org.eclipse.jetty.toolchain-jetty-servlet-api-4.0.9.jar Review Comment: Like `NOTICE-server.bin.txt`, these list items no longer include the leading indentation that existed previously. Consider restoring the indentation to match the rest of the file’s list formatting for consistency and easier review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
