djsweet commented on PR #4901: URL: https://github.com/apache/bookkeeper/pull/4901#issuecomment-5984800068
Thinking a bit more on this, I'm not sure this is a fully correct fix. Consider the scenario posed by #4900, but where the first ledger already exists, and is committed into InterleavedLedgerStorage. If you write to over 20,000 ledgers with small payloads below the `skipListSizeLimit`, then the call to `interleavedLedgerStorage.getLastAddConfirmed` will not be able to access the LAC from the Ledger Cache, but instead will read from the committed value in `InterleavedLedgerStorage`, which will be behind the LAC in the `memTable`. This means the LAC gets reset backwards, spuriously. #4902 always reads from the `entryMemTable` before `interleavedLedgerStorage`, so it shouldn't be susceptible to the same problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
