Repository: brooklyn-server
Updated Branches:
  refs/heads/master 20bc931d0 -> 9679a382b


Remove check for no-arg ctor in brooklyn:object DSL command


Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/9679a382
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/9679a382
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/9679a382

Branch: refs/heads/master
Commit: 9679a382b38c3768354e9aae43626ddbf8c94ae9
Parents: 20bc931
Author: Andrew Donald Kennedy <[email protected]>
Authored: Tue Aug 30 19:00:45 2016 +0100
Committer: Andrew Donald Kennedy <[email protected]>
Committed: Tue Aug 30 19:01:09 2016 +0100

----------------------------------------------------------------------
 .../camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java        | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/9679a382/camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java
----------------------------------------------------------------------
diff --git 
a/camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java
 
b/camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java
index 71bba2b..f579507 100644
--- 
a/camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java
+++ 
b/camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java
@@ -183,7 +183,7 @@ public class BrooklynDslCommon {
         List<Object> factoryMethodArgs = (List<Object>) 
config.getStringKeyMaybe("factoryMethod.args").or(ImmutableList.of());
         Map<String,Object> objectFields = (Map<String, Object>) 
config.getStringKeyMaybe("object.fields").or(MutableMap.of());
         Map<String,Object> brooklynConfig = (Map<String, Object>) 
config.getStringKeyMaybe(BrooklynCampReservedKeys.BROOKLYN_CONFIG).or(MutableMap.of());
-        
+
         String mappedTypeName = 
DeserializingClassRenamesProvider.findMappedName(typeName);
         Class<?> type;
         try {
@@ -193,9 +193,6 @@ public class BrooklynDslCommon {
             return new DslObject(mappedTypeName, constructorArgs, 
objectFields, brooklynConfig);
         }
 
-        if (!Reflections.hasNoArgConstructor(type)) {
-            throw new IllegalStateException(String.format("Cannot construct %s 
bean: No public no-arg constructor available", type));
-        }
         if (resolved(constructorArgs) && resolved(factoryMethodArgs) && 
resolved(objectFields.values()) && resolved(brooklynConfig.values())) {
             if (factoryMethodName == null) {
                 return DslObject.create(type, constructorArgs, objectFields, 
brooklynConfig);

Reply via email to