Review comment. Remove confusing default value. https://github.com/apache/brooklyn-server/pull/338#discussion_r94762563
Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/9369a42f Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/9369a42f Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/9369a42f Branch: refs/heads/master Commit: 9369a42fb9cf016cd5c118014c23e09e6085271b Parents: d3a64d9 Author: Geoff Macartney <[email protected]> Authored: Tue Feb 21 12:08:13 2017 +0000 Committer: Geoff Macartney <[email protected]> Committed: Thu Apr 20 11:20:36 2017 +0100 ---------------------------------------------------------------------- .../apache/brooklyn/core/mgmt/rebind/dto/AbstractMemento.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/9369a42f/core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/dto/AbstractMemento.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/dto/AbstractMemento.java b/core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/dto/AbstractMemento.java index 5a68b6a..876ab24 100644 --- a/core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/dto/AbstractMemento.java +++ b/core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/dto/AbstractMemento.java @@ -49,7 +49,7 @@ public abstract class AbstractMemento implements Memento, Serializable { protected String displayName; // catalogItemId is retained to support rebind of previously persisted state (prior to catalogItemHierarchy) protected String catalogItemId; - protected List<String> catalogItemHierarchy = MutableList.of(); + protected List<String> catalogItemHierarchy; protected Map<String, Object> customFields = Maps.newLinkedHashMap(); protected List<Object> tags = Lists.newArrayList(); protected Map<String,Set<String>> relations = Maps.newLinkedHashMap(); @@ -110,7 +110,7 @@ public abstract class AbstractMemento implements Memento, Serializable { */ protected String catalogItemId; - private List<String> catalogItemHierarchy = MutableList.of(); + private List<String> catalogItemHierarchy; private List<Object> tags; private Map<String,Set<String>> relations;
