address review comments - deprecated since 1.0.0 and one more method to deprecate
Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/de71fd48 Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/de71fd48 Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/de71fd48 Branch: refs/heads/master Commit: de71fd480586608bc8cf004ed89411a6273d417f Parents: 22178b6 Author: Alex Heneveld <[email protected]> Authored: Thu Oct 12 10:40:18 2017 +0100 Committer: Alex Heneveld <[email protected]> Committed: Thu Oct 12 10:40:18 2017 +0100 ---------------------------------------------------------------------- .../java/org/apache/brooklyn/core/sensor/AttributeMap.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/de71fd48/core/src/main/java/org/apache/brooklyn/core/sensor/AttributeMap.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/brooklyn/core/sensor/AttributeMap.java b/core/src/main/java/org/apache/brooklyn/core/sensor/AttributeMap.java index 1986a40..8cc7737 100644 --- a/core/src/main/java/org/apache/brooklyn/core/sensor/AttributeMap.java +++ b/core/src/main/java/org/apache/brooklyn/core/sensor/AttributeMap.java @@ -139,7 +139,7 @@ public final class AttributeMap { * @return the old value. * @throws IllegalArgumentException if path is null or empty * - * @deprecated since 0.13.0 becoming private; callers should only ever use {@link #update(AttributeSensor, Object)} + * @deprecated since 1.0.0 becoming private; callers should only ever use {@link #update(AttributeSensor, Object)} */ @Deprecated // TODO path must be ordered(and legal to contain duplicates like "a.b.a"; list would be better @@ -187,7 +187,7 @@ public final class AttributeMap { }); } - /** @deprecated since 0.13.0 this is becoming an internal method, {@link #updateInternalWithoutLockOrPublish(AttributeSensor, Object)} */ + /** @deprecated since 1.0.0 this is becoming an internal method, {@link #updateInternalWithoutLockOrPublish(AttributeSensor, Object)} */ @Deprecated public <T> T updateWithoutPublishing(AttributeSensor<T> attribute, T newValue) { return updateInternalWithoutLockOrPublish(attribute, newValue); @@ -247,7 +247,7 @@ public final class AttributeMap { } // TODO path must be ordered(and legal to contain duplicates like "a.b.a"; list would be better - /** @deprecated since 0.13.0 becoming private; callers should only ever use {@link #remove(AttributeSensor)} + /** @deprecated since 1.0.0 becoming private; callers should only ever use {@link #remove(AttributeSensor)} */ @Deprecated public void remove(Collection<String> path) { @@ -266,7 +266,9 @@ public final class AttributeMap { * @param path the path of the value to get * @return the value * @throws IllegalArgumentException path is null or empty. + * @deprecated since 1.0.0 becoming private; callers should only ever use {@link #getValue(AttributeSensor)} */ + @Deprecated public Object getValue(Collection<String> path) { checkPath(path); Object result = values.get(path);
