This is an automated email from the ASF dual-hosted git repository. heneveld pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brooklyn-server.git
commit bd686f1d21c8114e9ddf158891104f88957aca5a Author: Alex Heneveld <[email protected]> AuthorDate: Tue Jan 15 10:44:49 2019 +0000 add comments to AnyoneSecProvs --- .../brooklyn/rest/security/provider/AnyoneSecurityProvider.java | 5 ++++- .../rest/entitlement/AuthenticateAnyoneSecurityProvider.java | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/rest/rest-resources/src/main/java/org/apache/brooklyn/rest/security/provider/AnyoneSecurityProvider.java b/rest/rest-resources/src/main/java/org/apache/brooklyn/rest/security/provider/AnyoneSecurityProvider.java index 7aa9ab3..06e255a 100644 --- a/rest/rest-resources/src/main/java/org/apache/brooklyn/rest/security/provider/AnyoneSecurityProvider.java +++ b/rest/rest-resources/src/main/java/org/apache/brooklyn/rest/security/provider/AnyoneSecurityProvider.java @@ -20,7 +20,8 @@ package org.apache.brooklyn.rest.security.provider; import javax.servlet.http.HttpSession; -/** provider who allows everyone, but does require a user/pass to be provided */ +/** provider who allows all access with no need to supply a user + * (see also test case AuthenticateAnyoneSecurityProvider) */ public class AnyoneSecurityProvider implements SecurityProvider { @Override @@ -30,11 +31,13 @@ public class AnyoneSecurityProvider implements SecurityProvider { @Override public boolean requiresUserPass() { + // doesn't matter as isAuth always returns true, this should never be called return true; } @Override public boolean authenticate(HttpSession session, String user, String password) { + // doesn't matter as isAuth always returns true, this should never be called return true; } diff --git a/rest/rest-server/src/test/java/org/apache/brooklyn/rest/entitlement/AuthenticateAnyoneSecurityProvider.java b/rest/rest-server/src/test/java/org/apache/brooklyn/rest/entitlement/AuthenticateAnyoneSecurityProvider.java index d231886..5ed763d 100644 --- a/rest/rest-server/src/test/java/org/apache/brooklyn/rest/entitlement/AuthenticateAnyoneSecurityProvider.java +++ b/rest/rest-server/src/test/java/org/apache/brooklyn/rest/entitlement/AuthenticateAnyoneSecurityProvider.java @@ -20,8 +20,11 @@ package org.apache.brooklyn.rest.entitlement; import javax.servlet.http.HttpSession; +import org.apache.brooklyn.rest.security.provider.AnyoneSecurityProvider; import org.apache.brooklyn.rest.security.provider.SecurityProvider; +/** allows anyone to access, but does require a non-null user (any password) to be supplied via Basic auth, + * in contrast to {@link AnyoneSecurityProvider} */ public class AuthenticateAnyoneSecurityProvider implements SecurityProvider { @Override @@ -43,4 +46,4 @@ public class AuthenticateAnyoneSecurityProvider implements SecurityProvider { public boolean requiresUserPass() { return true; } -} \ No newline at end of file +}
