This is an automated email from the ASF dual-hosted git repository.

heneveld pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brooklyn-ui.git


The following commit(s) were added to refs/heads/master by this push:
     new 0f5f5db  Remove the reserved keyword check for config key. It makes 
sense to do this for metadata (we don't want to override `brooklyn.enrichers` 
or `name`) but not for keys within `brooklyn.config`
     new 152226f  This closes #138
0f5f5db is described below

commit 0f5f5db4157b0ab6e5b7daa4e9f8d3e16ba4aa05
Author: Thomas Bouron <[email protected]>
AuthorDate: Thu Sep 12 13:56:49 2019 +0100

    Remove the reserved keyword check for config key. It makes sense to do this 
for metadata (we don't want to override `brooklyn.enrichers` or `name`) but not 
for keys within `brooklyn.config`
---
 .../app/components/spec-editor/spec-editor.directive.js               | 4 ----
 1 file changed, 4 deletions(-)

diff --git 
a/ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
 
b/ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
index 00f2467..4930f21 100644
--- 
a/ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
+++ 
b/ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
@@ -836,10 +836,6 @@ export function specEditorDirective($rootScope, 
$templateCache, $injector, $sani
             let modelConfig = scope.model.config;
             let result = {};
             for (let [key, value] of modelConfig) {
-                if (blueprintService.isReservedKey(key)) {
-                    $log.warn("skipping reserved word used as config key", 
key);
-                    continue; // skip
-                }
                 result[key] = getLocalConfigValueFromModelValue(key, value);
             }
             scope.config = result;

Reply via email to