This is an automated email from the ASF dual-hosted git repository. heneveld pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brooklyn-ui.git
commit 50e6787d2af2f4eaf9a1e99db296be3aa80e38a7 Author: Alex Heneveld <[email protected]> AuthorDate: Wed Oct 5 15:51:51 2022 +0100 workflow ui tidies following review --- .../app/components/workflow/workflow-steps.directive.js | 8 ++++---- .../app-inspector/app/components/workflow/workflow-steps.less | 8 +++++++- .../app/components/workflow/workflow-steps.template.html | 2 +- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/ui-modules/app-inspector/app/components/workflow/workflow-steps.directive.js b/ui-modules/app-inspector/app/components/workflow/workflow-steps.directive.js index 8eb950d0..e81fa495 100644 --- a/ui-modules/app-inspector/app/components/workflow/workflow-steps.directive.js +++ b/ui-modules/app-inspector/app/components/workflow/workflow-steps.directive.js @@ -221,11 +221,11 @@ function makeArrows(workflow, steps) { } if (prev > i) rank = rank + 0.5; width = 0.2 + 0.6 * (rank + 0.5) / (jumpSizes.length + 0.5); - // curveX = 0.8 + 0.2*width; - // curveY = 0.8 + 0.2*width; + curveX = 0.8 + 0.2*width; + curveY = 0.8 + 0.2*width; // higher values (above) look nicer, but make disambiguation of complex paths harder - curveX = 0.5 + 0.3*width; - curveY = 0.4 + 0.4*width; + // curveX = 0.5 + 0.3*width; + // curveY = 0.4 + 0.4*width; } return arrowStep(prev, i, {hideArrowhead: prev==i, width, curveX, curveY, ...opts}); } diff --git a/ui-modules/app-inspector/app/components/workflow/workflow-steps.less b/ui-modules/app-inspector/app/components/workflow/workflow-steps.less index 2c067037..59f2a854 100644 --- a/ui-modules/app-inspector/app/components/workflow/workflow-steps.less +++ b/ui-modules/app-inspector/app/components/workflow/workflow-steps.less @@ -89,7 +89,7 @@ .step-name { font-weight: 600; - font-size: 100%; + font-size: 90%; } .step-id { @@ -249,4 +249,10 @@ overflow: hidden; } + svg.workflow-arrows { + //opacity: 10%; + } + svg.workflow-arrows:hover { + opacity: 100%; + } } diff --git a/ui-modules/app-inspector/app/components/workflow/workflow-steps.template.html b/ui-modules/app-inspector/app/components/workflow/workflow-steps.template.html index 309ce4a2..b571686e 100644 --- a/ui-modules/app-inspector/app/components/workflow/workflow-steps.template.html +++ b/ui-modules/app-inspector/app/components/workflow/workflow-steps.template.html @@ -18,7 +18,7 @@ --> <div class="workflow-steps" ng-class="vm.getWorkflowStepsClasses()"> - <svg width="100%" height="100%" style="position: absolute;"> + <svg width="100%" height="100%" style="position: absolute;" class="workflow-arrows"> <g transform="scale(-1,1)" transform-origin="center" id="workflow-step-arrows"> </g> </svg>
