[brooklyn-server] branch master updated: more logging of errors from the rest api

[heneveld]

This is an automated email from the ASF dual-hosted git repository.

heneveld pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brooklyn-server.git


The following commit(s) were added to refs/heads/master by this push:
     new 58aabbece0 more logging of errors from the rest api
58aabbece0 is described below

commit 58aabbece04bb04b86bdc2d7587dadc306b973e9
Author: Alex Heneveld <a...@cloudsoft.io>
AuthorDate: Wed Mar 1 10:59:03 2023 +0000

    more logging of errors from the rest api
---
 .../apache/brooklyn/rest/util/DefaultExceptionMapper.java    | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git 
a/rest/rest-resources/src/main/java/org/apache/brooklyn/rest/util/DefaultExceptionMapper.java
 
b/rest/rest-resources/src/main/java/org/apache/brooklyn/rest/util/DefaultExceptionMapper.java
index 89888158f6..0361c7c47a 100644
--- 
a/rest/rest-resources/src/main/java/org/apache/brooklyn/rest/util/DefaultExceptionMapper.java
+++ 
b/rest/rest-resources/src/main/java/org/apache/brooklyn/rest/util/DefaultExceptionMapper.java
@@ -103,7 +103,7 @@ public class DefaultExceptionMapper implements 
ExceptionMapper<Throwable> {
             return 
ApiError.builder().message(throwable2.getMessage()).prefixMessage("Invalid 
YAML").build().asBadRequestResponseJson();
         }
 
-        if (!Exceptions.isPrefixBoring(throwable2)) {
+        if (!isTooUninterestingToLogWarn(throwable2)) {
             if ( encounteredUnknownExceptions.add( throwable2.getClass() )) {
                 LOG.warn("REST call generated exception type 
"+throwable2.getClass()+" unrecognized in "+getClass()+" (subsequent 
occurrences will be logged debug only): " + throwable2, throwable2);
             }
@@ -120,7 +120,15 @@ public class DefaultExceptionMapper implements 
ExceptionMapper<Throwable> {
             rb.message("Internal error. Contact server administrator to 
consult logs for more details.");
         return rb.build().asResponse(Status.INTERNAL_SERVER_ERROR, 
MediaType.APPLICATION_JSON_TYPE);
     }
-    
+
+    protected boolean isTooUninterestingToLogWarn(Throwable throwable2) {
+        // we used to do this which excluded too much
+        //return Exceptions.isPrefixBoring(throwable2);
+
+        // for now we do this which probably includes some things we'd like to 
suppress (eg when starting up) but we can improve subsequently
+        return false;
+    }
+
     /** Logs full details at trace, unless it is the first time we've seen 
this in which case it is debug */
     @Beta
     public static void logExceptionDetailsForDebugging(Throwable t) {