This is an automated email from the ASF dual-hosted git repository. heneveld pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brooklyn-server.git
commit ebe5f0143c91bb006eae8e1cdbaa17905ca08b2e Author: Alex Heneveld <[email protected]> AuthorDate: Tue Jun 6 21:11:06 2023 +0100 update description and comment on workflow lock field --- .../apache/brooklyn/core/workflow/WorkflowCommonConfig.java | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/core/src/main/java/org/apache/brooklyn/core/workflow/WorkflowCommonConfig.java b/core/src/main/java/org/apache/brooklyn/core/workflow/WorkflowCommonConfig.java index 142c7deddd..b48830851d 100644 --- a/core/src/main/java/org/apache/brooklyn/core/workflow/WorkflowCommonConfig.java +++ b/core/src/main/java/org/apache/brooklyn/core/workflow/WorkflowCommonConfig.java @@ -60,12 +60,9 @@ public interface WorkflowCommonConfig { ConfigKey<Duration> TIMEOUT = ConfigKeys.newConfigKey(Duration.class, "timeout", "Time after which a workflow should be automatically interrupted and failed"); - // TODO only string supported so far, but could be more allowing more configurable lock behaviour - // - the entity where to read/write the sensor - // - full sensor name (default would be a suffix) - // - a `value` to set - // - a condition to `require` of the value - // - a `retry` specification - ConfigKey<Object> LOCK = ConfigKeys.newConfigKey(Object.class, "lock"); + // could support a condition to require, a value to set, and/or a retry spec; but that seems overly complicated + ConfigKey<Object> LOCK = ConfigKeys.newConfigKey(Object.class, "lock", + "Mutex lock that should be held by the workflow, either a string (used in name of sensor) or " + + "a map of {entity,name} where the name is the name to be used for a lock sensor to acquire from another entity"); }
