This is an automated email from the ASF dual-hosted git repository.

heneveld pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brooklyn-server.git

commit 8fe9c4fc1bfe9ee75e0e7ae00228af95fa3cae26
Author: Alex Heneveld <[email protected]>
AuthorDate: Fri Jun 23 21:19:48 2023 +0100

    don't warn if an active task deletes itself
    
    this happens eg for workflows that are expiring after completed in their 
task
---
 .../org/apache/brooklyn/util/core/task/BasicExecutionManager.java     | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git 
a/core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java
 
b/core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java
index 97e63bedce..26756368f1 100644
--- 
a/core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java
+++ 
b/core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java
@@ -487,8 +487,10 @@ public class BasicExecutionManager implements 
ExecutionManager {
 
                 if (debugOnly) {
                     log.debug("Deleting cancelled task before completion: " + 
removedById + "; this task will continue to run in the background outwith " + 
this);
+                } else if (removedById.equals(Tasks.current())) {
+                    log.debug("Deleting currently running task "+removedById+" 
from memory; normal on tasks that do not want to be remembered but if not done 
carefully subsequent interaction capabilities may be limited");
                 } else {
-                    log.warn("Deleting submitted task before completion: " + 
removedById + " (tags " + removedById.getTags() + "); this task will continue 
to run in the background outwith " + this + ", but perhaps it should have been 
cancelled?");
+                    log.warn("Deleting submitted task before completion: " + 
removedById + " (tags " + removedById.getTags() + "), submitted by 
"+Tasks.current()+"; deleted task will continue to run in the background 
outwith " + this + ", but perhaps it should have been cancelled?");
                     log.debug("Active task deletion trace", new 
Throwable("Active task deletion trace"));
                 }
             }

Reply via email to