This is an automated email from the ASF dual-hosted git repository.

heneveld pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brooklyn-ui.git

commit 53f297ebaccb47dfb5f37a9157d0498ba1b78986
Author: Alex Heneveld <[email protected]>
AuthorDate: Wed Jun 21 15:23:56 2023 +0100

    better display for fringe error cases
    
    if error occurs prior to running a step, output could be clearer
---
 .../app/components/workflow/workflow-step.template.html              | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/ui-modules/app-inspector/app/components/workflow/workflow-step.template.html 
b/ui-modules/app-inspector/app/components/workflow/workflow-step.template.html
index 1f612cff..6a542b17 100644
--- 
a/ui-modules/app-inspector/app/components/workflow/workflow-step.template.html
+++ 
b/ui-modules/app-inspector/app/components/workflow/workflow-step.template.html
@@ -46,13 +46,13 @@
                 <i class="fa fa-id-card-o"></i>
                 {{ stepTitle.id }}
             </div>
-            <div ng-if="stepTitle.id && !isFocusTask" 
class="workflow-step-pill step-id handy"
+            <div ng-if="stepTitle.id && !isFocusTask && stepContext.taskId" 
class="workflow-step-pill step-id handy"
                     title="Select this task"
                     ui-sref="main.inspect.activities.detail({applicationId: 
workflow.applicationId, entityId: workflow.entityId, activityId: 
stepContext.taskId, workflowId })">
                 <i class="fa fa-id-card-o"></i>
                 {{ stepTitle.id }}
             </div>
-            <div ng-if="!stepTitle.id && !isFocusTask" 
class="workflow-step-pill step-id handy hover-only"
+            <div ng-if="!stepTitle.id && !isFocusTask && stepContext.taskId" 
class="workflow-step-pill step-id handy hover-only"
                  title="Select this task"
                  ui-sref="main.inspect.activities.detail({applicationId: 
workflow.applicationId, entityId: workflow.entityId, activityId: 
stepContext.taskId, workflowId })">
                 <i class="fa fa-id-card-o"></i>
@@ -74,6 +74,7 @@
                 <div>
                     <span ng-if="!osi.countStarted" class="space-above">
                         This step has not been run<span ng-if="isRunning"> 
yet</span>.
+                        {{ stepCurrentError ? 'There was an error prior to 
running this step. More information can be found in the Details panel on the 
task for the workflow.' : '' }}
                     </span>
                     <span ng-if="osi.countStarted">
                         <span ng-if="osi.countCompleted == osi.countStarted">

Reply via email to