Adds TODO question to Networking.isReaachable Project: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/commit/3fe1d9d7 Tree: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/tree/3fe1d9d7 Diff: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/diff/3fe1d9d7
Branch: refs/heads/master Commit: 3fe1d9d758e113fc05a59f7e9fb86f2c14bba5e2 Parents: 4cc09b0 Author: Aled Sage <[email protected]> Authored: Mon Nov 9 08:28:56 2015 +0000 Committer: Aled Sage <[email protected]> Committed: Tue Nov 17 17:49:26 2015 +0000 ---------------------------------------------------------------------- .../main/java/org/apache/brooklyn/util/net/Networking.java | 7 +++++++ 1 file changed, 7 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/blob/3fe1d9d7/utils/common/src/main/java/org/apache/brooklyn/util/net/Networking.java ---------------------------------------------------------------------- diff --git a/utils/common/src/main/java/org/apache/brooklyn/util/net/Networking.java b/utils/common/src/main/java/org/apache/brooklyn/util/net/Networking.java index 695e3f8..fb988c7 100644 --- a/utils/common/src/main/java/org/apache/brooklyn/util/net/Networking.java +++ b/utils/common/src/main/java/org/apache/brooklyn/util/net/Networking.java @@ -26,6 +26,7 @@ import java.net.NetworkInterface; import java.net.ServerSocket; import java.net.Socket; import java.net.SocketException; +import java.net.URI; import java.net.UnknownHostException; import java.util.Arrays; import java.util.Enumeration; @@ -486,6 +487,12 @@ public class Networking { } public static boolean isReachable(HostAndPort endpoint) { + // TODO Should we create an unconnected socket, and then use the calls below (see jclouds' InetSocketAddressConnect): + // socket.setReuseAddress(false); + // socket.setSoLinger(false, 1); + // socket.setSoTimeout(timeout); + // socket.connect(socketAddress, timeout); + try { Socket s = new Socket(endpoint.getHostText(), endpoint.getPort()); closeQuietly(s);
