Failures not reported correclty for ScalaTest (fix included)
------------------------------------------------------------
Key: BUILDR-307
URL: https://issues.apache.org/jira/browse/BUILDR-307
Project: Buildr
Issue Type: Bug
Components: Test frameworks
Affects Versions: 1.3.4, 1.3.5
Environment: all
Reporter: Jeremie Lenfant-Engelmann
Fix For: 1.3.5, 1.3.4
Today when a ScalaTest fails Buildr doesn't report it correctly and just ends
without reporting the correct error or returning an error code.
There is 2 problems:
- The regexp used to now if a test failed is wrong
- The loop reading the reportFile breaks too early, it breaks on the sentence
'Run completed.' but 'TEST FAILED' is on the following line
Here is a fix for it:
Index: lib/buildr/scala/tests.rb
===================================================================
--- lib/buildr/scala/tests.rb (revision 811837)
+++ lib/buildr/scala/tests.rb (working copy)
@@ -126,9 +126,9 @@
while (!completed) do
File.open(reportFile, "r") do |input|
while (line = input.gets) do
- failed = (line =~ /(TEST FAILED -)|(RUN STOPPED)|(RUN ABORTED)/)
unless failed
+ failed = (line =~ /(TESTS? FAILED)|(RUN STOPPED)|(RUN ABORTED)/)
unless failed
completed |= (line =~ /Run completed\./)
- break if (failed || completed)
+ break if (failed)
end
end
wait += 1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
