[ 
https://issues.apache.org/jira/browse/BUILDR-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexis Midon updated BUILDR-223:
--------------------------------

    Attachment: buildr-223.patch.txt

I just noticed that the methods commit_message and tag_name do not work as 
advertised.
Actually these methods are currently defined as instance methods not class 
methods. 
So Release.tag_name= "" fails. The workaround is to used Release.find.tag_name 
= ""

Anyway, here is a patch to fix this. Specs are adjusted as well.

The fix removes the instance methods, you might want to keep them around and 
make them fail with a clear explanation or print a deprecated message.


> Release Task: customizable commit message
> -----------------------------------------
>
>                 Key: BUILDR-223
>                 URL: https://issues.apache.org/jira/browse/BUILDR-223
>             Project: Buildr
>          Issue Type: New Feature
>          Components: Core features
>            Reporter: Alexis Midon
>             Fix For: 1.3.4
>
>         Attachments: buildr-223.patch.txt
>
>
> From a request on nuildr-dev mailing list:
> Next, our commit messages have a special format (we start with keywords), and 
> we cannot use the buildr release without modifications.
>  I can patch the Release class in my buildfile, but perhaps something similar 
> to the release attribute in buildr 1.3.3 would be possible, like in the
>  following exemple ?
>  Release.tag_name = lambda { |ver| "foo-#{ver}" }
>  Release.commit_format = lambda { |msg| "ADD: #{msg}" }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to