Author: boisvert
Date: Mon Dec 28 22:58:37 2009
New Revision: 894268
URL: http://svn.apache.org/viewvc?rev=894268&view=rev
Log:
A version number should start with a digit
Modified:
buildr/trunk/lib/buildr/packaging/version_requirement.rb
buildr/trunk/spec/version_requirement_spec.rb
Modified: buildr/trunk/lib/buildr/packaging/version_requirement.rb
URL:
http://svn.apache.org/viewvc/buildr/trunk/lib/buildr/packaging/version_requirement.rb?rev=894268&r1=894267&r2=894268&view=diff
==============================================================================
--- buildr/trunk/lib/buildr/packaging/version_requirement.rb (original)
+++ buildr/trunk/lib/buildr/packaging/version_requirement.rb Mon Dec 28
22:58:37 2009
@@ -29,7 +29,7 @@
class << self
# is +str+ a version string?
def version?(str)
- /^\s*[#{VER_CHARS}]+\s*$/ === str
+ /^\s*\d[#{VER_CHARS}]*\s*$/ === str
end
# is +str+ a version requirement?
Modified: buildr/trunk/spec/version_requirement_spec.rb
URL:
http://svn.apache.org/viewvc/buildr/trunk/spec/version_requirement_spec.rb?rev=894268&r1=894267&r2=894268&view=diff
==============================================================================
--- buildr/trunk/spec/version_requirement_spec.rb (original)
+++ buildr/trunk/spec/version_requirement_spec.rb Mon Dec 28 22:58:37 2009
@@ -127,3 +127,17 @@
Buildr::VersionRequirement.create('1 & 2 | 3').default.should == '3'
end
end
+
+describe Buildr::VersionRequirement, '#version?' do
+ it 'should identify valid versions' do
+ Buildr::VersionRequirement.version?('1').should be_true
+ Buildr::VersionRequirement.version?('1a').should be_true
+ Buildr::VersionRequirement.version?('1.0').should be_true
+ Buildr::VersionRequirement.version?('11.0').should be_true
+ Buildr::VersionRequirement.version?(' 11.0 ').should be_true
+ Buildr::VersionRequirement.version?('11.0-alpha').should be_true
+
+ Buildr::VersionRequirement.version?('a').should be_false
+ Buildr::VersionRequirement.version?('a1').should be_false
+ end
+end
